Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Script: 2FAuth #943

Merged
merged 28 commits into from
Dec 26, 2024
Merged

New Script: 2FAuth #943

merged 28 commits into from
Dec 26, 2024

Conversation

jkrgr0
Copy link
Contributor

@jkrgr0 jkrgr0 commented Dec 20, 2024

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Created install script for 2FAuth.



🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

None

@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Dec 20, 2024
@jkrgr0 jkrgr0 marked this pull request as ready for review December 20, 2024 13:32
@jkrgr0 jkrgr0 requested a review from a team as a code owner December 20, 2024 13:32
@MickLesk
Copy link
Member

before i review it, 512mb ram and 1 core is really enough for php artisan?^^

@jkrgr0
Copy link
Contributor Author

jkrgr0 commented Dec 20, 2024

oops, forgot to change the default values.

After creating the PR, I had the idea of possibly switching to SQLite. This should be enough for the basic operation with a few users.

I set the PR to draft again and apply the changes.

@jkrgr0 jkrgr0 marked this pull request as draft December 20, 2024 14:44
Copy link
Member

@michelroegl-brunner michelroegl-brunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First little review on mobile. I will have a second look later :)

ct/2fauth.sh Outdated Show resolved Hide resolved
ct/2fauth.sh Outdated Show resolved Hide resolved
ct/2fauth.sh Outdated Show resolved Hide resolved
install/2fauth-install.sh Outdated Show resolved Hide resolved
install/2fauth-install.sh Outdated Show resolved Hide resolved
install/2fauth-install.sh Outdated Show resolved Hide resolved
install/2fauth-install.sh Outdated Show resolved Hide resolved
ct/2fauth.sh Outdated Show resolved Hide resolved
@MickLesk
Copy link
Member

oops, forgot to change the default values.

After creating the PR, I had the idea of possibly switching to SQLite. This should be enough for the basic operation with a few users.

I set the PR to draft again and apply the changes.

MySQL is fine too. I always prefer pgsql

@github-actions github-actions bot added the high risk A change that can affect many scripts label Dec 23, 2024
@jkrgr0
Copy link
Contributor Author

jkrgr0 commented Dec 23, 2024

Regarding the default settings of 1 core and 512MB RAM: It seems the app is cool with such low resources.
In my test setup I've added a few tokens (single user) and the CPU usage is near 1%, RAM usage is ~100MiB. The webapp is smooth, so no long waiting periods or similar.
So probably the resources should be enough for a start.

@jkrgr0 jkrgr0 marked this pull request as ready for review December 23, 2024 14:07
@MickLesk MickLesk removed the high risk A change that can affect many scripts label Dec 26, 2024
@MickLesk MickLesk merged commit b30e8c5 into community-scripts:main Dec 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants