-
-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial PR for Contributing & Coding Standard #920
base: main
Are you sure you want to change the base?
Conversation
* Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md
"type": "ct", | ||
"updateable": true, | ||
"privileged": false, | ||
"interface_port": DEFAULT-PORT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use something representative for this example, either 80 or 8080
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do.
But you can also change in the branch as you like.
Great stuff overall. Sorry I pushed a commit directly fixing typos (I thought it would create a review). I'm ok with this but I suggest going over it again, there seems to be a lot of typos. Not sure why some stuff are capitalized either (Coding standards, Application...). And why the AppName.md? Is that something new with the big update you did? Never seen that before. |
Thank you. And no worries about the push, you can and should edit as you see fit. |
✍️ Description
remove old contributing.md
add new contributing.md
First Draft, added some functionality and descriptions later
Every @community-scripts/contributor are welcome to improve this PR
🛠️ Type of Change
Please check the relevant options:
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
📋 Additional Information (optional)
Provide any extra context or screenshots about the feature or fix here.