Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR-Template #901

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michelroegl-brunner
Copy link
Member

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Update the template to prompt the user to include a link to the script for easy testing.


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

pr_temp

@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner December 18, 2024 14:04
@github-actions github-actions bot added the maintenance Code maintenance or general upkeep of the project label Dec 18, 2024
@MickLesk
Copy link
Member

Not yet. We need to change the branches, probably I see it that we run all PR's in the DEV branch to have a direct test experience. They will then be migrated from group X to main. It's all still very sketchy at the moment, but we'll see.

@remz1337
Copy link
Contributor

Yea I agree with Mick, running things off of other people's repo is sketchy. I would prefer a workflow like this:

  1. We review the code visually
  2. when code is acceptable, we pull into dev branch to test
  3. If testing is successful, we promote from dev to main

@michelroegl-brunner
Copy link
Member Author

Yes, i see the Problems there. I just catched my eye with the latest new script PR. I just thought "And how do we test it now".
This PR was intended as Quick fix until a better designed Workflow is implemented.
But i like your train of thought!

@MickLesk MickLesk marked this pull request as draft December 26, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code maintenance or general upkeep of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants