Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #224

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Merge #224

merged 2 commits into from
Nov 13, 2024

Conversation

MickLesk
Copy link
Member

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Provide a summary of the changes made and/or reference the issue being addressed.

Fixes # (issue)

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

MickLesk and others added 2 commits November 13, 2024 15:05
* Update mariadb.json

* Update vaultwarden.json

* Update vaultwarden.json

* Update keycloak.json

* Update json/keycloak.json

Co-authored-by: Håvard Gjøby Thom <[email protected]>

* Update mariadb.json

Co-authored-by: Håvard Gjøby Thom <[email protected]>

* Add canonical link to layout for improved SEO and page indexing

* Fix image source fallback for script logos to use a consistent relative path

* Fix image source for script logos across components to consistently use the "/ProxmoxVE/logo.png" path

* Update image source for script logos to use basePath for consistent paths across all components

* Fix image source for script logos to ensure leading slash is consistent for all components' paths

---------

Co-authored-by: CanbiZ <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
@MickLesk MickLesk requested review from a team as code owners November 13, 2024 15:48
@MickLesk MickLesk merged commit 321a565 into MickLesk_Dev Nov 13, 2024
4 checks passed
@havardthom
Copy link
Contributor

@MickLesk Could you use a fork for development instead, these merges notifies everyone

@MickLesk
Copy link
Member Author

@MickLesk Could you use a fork for development instead, these merges notifies everyone

okay, what a bullshit 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants