Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config template in blocky-install.sh #1059

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xFichtl1
Copy link

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Provide a summary of the changes made and/or reference the issue being addressed.
Some configurations in blocky changed since the last time, like changing the names of BlackLists/WhiteLists to DenyLists/AllowLists. I took the current reference configuration file (https://0xerr0r.github.io/blocky/latest/configuration/) and commented out unnecessary configs, like the old configuration did.


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

@xFichtl1 xFichtl1 requested a review from a team as a code owner December 28, 2024 09:42
@github-actions github-actions bot added the update script A change that updates a script label Dec 28, 2024
@michelroegl-brunner
Copy link
Member

Looks ok to me. The question i have. Maybe you can tidy this up a bit and remove all unneeded, commented lines, so the script is not so bloated?

@MickLesk
Copy link
Member

300 lines of sample code.
Can you shrink into max. 20-30 Lines with an URL to an full documentation about all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants