Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Base Scripts Tag to proxmox-helper-scripts #1038

Closed
wants to merge 2 commits into from

Conversation

TheRealVira
Copy link
Contributor

✍️ Description

It seems like a new tag has been introduced, which is kinda breaking backwards-comparability.


Please remove unneeded lines!


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

With this PR I re-introduce the old "proxmox-helper-scripts" tag isntead of having a new "community-script" tag.

@TheRealVira TheRealVira requested a review from a team as a code owner December 27, 2024 15:03
@github-actions github-actions bot added the high risk A change that can affect many scripts label Dec 27, 2024
@MickLesk
Copy link
Member

And what's the problem? There can't be a problem.

@TheRealVira
Copy link
Contributor Author

And what's the problem? There can't be a problem.

The problem is that there are now two different tags for the same category (community proxmox helper scripts). It gets a different color and it makes filtering/managing resources more tedious. Plus, it will be more difficult to maintain if we get more tag related features (like backup jobs based on tags e.g.).

@MickLesk
Copy link
Member

Simply remove the old tag. I am of the opinion that this change is unnecessary. Especially since most updated scripts / users now use the new tag. This also allows us to see whether it is a new script or an old script.

@MickLesk MickLesk closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high risk A change that can affect many scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants