Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update files to end with only one newline and update pre-commit config to include "end-of-file-fixer" & "mixed-line-ending" #1185

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Jan 18, 2024

References:

Many older tools misbehave if the last line of data in a text file is not terminated with a newline or carriage return / new line combination. They ignore that line as it is terminated with ^Z (eof) instead.

Source: https://stackoverflow.com/questions/2287967/why-is-it-recommended-to-have-empty-line-in-the-end-of-a-source-file

By adding `end-of-file-fixer` to the pre-commit configuration, it enables
"GitHub Action report" and "local pre-commit checks".

See https://github.com/pre-commit/pre-commit-hooks#end-of-file-fixer
By adding `mixed-line-ending` to the pre-commit configuration, it enables
"GitHub Action report" and "local pre-commit checks".

See https://github.com/pre-commit/pre-commit-hooks#mixed-line-ending
@jcfr jcfr merged commit 45f33c8 into commontk:master Jan 18, 2024
2 of 3 checks passed
@jcfr jcfr deleted the end-of-file-fixer-and-mixed-line-ending branch January 18, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant