Fix parallel execution of DICOM tests #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tags Follow-up of 73ab63a ("BUG: Fix ctkDICOMDatabaseTest2 comparing upper-cased tag", 2024-01-12)
jcfr
force-pushed
the
fix-parallel-execution-of-dicom-tests
branch
from
9bb474b
to
72778f1
Compare
The CTest driver automatically updates the first argument to match the test name. This commit ensures that only one argument is removed from the list before retrieving test-specific arguments, if any. Switch all DICOM tests to process arguments using the list returned by `QCoreApplication::arguments()`. Additionally, it updates the use of the command line parser in `ctkFileDialogTest1`. Co-authored-by: Davide Punzo <[email protected]>
This will prevent the following test from all running in parallel with a `dcmqrscp` executable configured to listen on the same port. Tests either using "dcmqrscp" executable directly or through the `ctkDICOMTester` helper class: * ctkDICOMApplicationTest1 * ctkDICOMQueryTest2 * ctkDICOMRetrieveTest2 * ctkDICOMTesterTest1 * ctkDICOMTesterTest2
jcfr
force-pushed
the
fix-parallel-execution-of-dicom-tests
branch
from
72778f1
to
d49a7a9
Compare
…uction Since the DCMTK executable do not seem to configure a termination handler on windows (using `SetConsoleCtrlHandler()`) or on Unix (using `sigaction()`), we speed up testing by simply killing the process. > On Windows, terminate() posts a WM_CLOSE message to all top-level > windows of the process and then to the main thread of the process > itself. On Unix and macOS the SIGTERM signal is sent. > > Console applications on Windows that do not run an event loop, or whose > event loop does not handle the WM_CLOSE message, can only be terminated > by calling kill(). Source: https://doc.qt.io/qt-5/qprocess.html#terminate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctkDICOMDatabaseTest2to test use of lower and upper case tagsdcmqrscpin parallel