Fix segault in ctkFileDialog::selectionMode() with native dialogs & improve ctkFileDialogTest1 #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
force-pushed
the
fix-ctkFileDialogTest1
branch
2 times, most recently
from
3a27edc
to
6c7f5e0
Compare
Follow-up of c4f1eee ("ENH: Update ctkFileDialog to use native dialog by default", 2021-06-10).
…mes & args Approach similar to the one already used with "simple_test_with_data" and originally contributed in commit 78632c0 ("BUG: Improve simple_test_with_data macro to ensure MagnifyView tests are executed", 2018-11-15)
jcfr
force-pushed
the
fix-ctkFileDialogTest1
branch
from
6c7f5e0
to
13ba762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctkFileDialog::selectionMode()with native dialogsctkFileDialogTest1to checkUseNativeDialogs&DoNotUseNativeDialogs