Simplify DICOM testing removing needs for installing CTK #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be integrated after #1166 |
Update test to explicitly pass the path to the ctkDICOMHost executable.
This removes the requirement to install CTK into the `CMakeExternals/Install` directory.
jcfr
force-pushed
the
simplify-dicom-testing
branch
from
eecb9d2
to
5fd9870
Compare
|
Now working on addressing #1165 (comment) to ensure the environment is properly setup to remove the need for manually setting |
|
Support for setting the test launching environment will be integrated independently. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctkDICOMTesterto lookup DCMTK executables in build tree. This removes the requirement to install CTK into theCMakeExternals/Installdirectory.ctkDICOMHostTest1without having to install CTKctkDICOMDatabasetests in parallel usingQTemporaryDirintroduced in Qt5