-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Minor improvements for the visual DICOM browser #1163
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andras Lasso <[email protected]>
Co-authored-by: Andras Lasso <[email protected]>
Co-authored-by: Andras Lasso <[email protected]>
@lassoan this is needed for Slicer/Slicer#7525 |
Punzo
force-pushed
the
VisualDICOMBrowserENH1
branch
3 times, most recently
from
January 11, 2024 21:24
9797afc
to
c04bc2f
Compare
Punzo
force-pushed
the
VisualDICOMBrowserENH1
branch
from
January 11, 2024 21:34
c04bc2f
to
689972f
Compare
Punzo
changed the title
ENH: Apply Andras' feedback
ENH: Minor improvements for the visual DICOM browser
Jan 11, 2024
lassoan
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, this looks good to me. I've added a few minor issues to #1162.
I will take of this in the coming hour 👌 |
Great, thank you! |
Closing. Superseded by #1165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply high priority feedback from Andras from Slicer/Slicer#7525 (review)
I will mark this PR when I will have finished