Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Minor improvements for the visual DICOM browser #1163

Closed
wants to merge 8 commits into from

Conversation

Punzo
Copy link
Contributor

@Punzo Punzo commented Jan 10, 2024

Apply high priority feedback from Andras from Slicer/Slicer#7525 (review)

I will mark this PR when I will have finished

@Punzo Punzo marked this pull request as ready for review January 11, 2024 20:22
@Punzo
Copy link
Contributor Author

Punzo commented Jan 11, 2024

@lassoan this is needed for Slicer/Slicer#7525

@Punzo Punzo force-pushed the VisualDICOMBrowserENH1 branch 3 times, most recently from 9797afc to c04bc2f Compare January 11, 2024 21:24
@Punzo Punzo changed the title ENH: Apply Andras' feedback ENH: Minor improvements for the visual DICOM browser Jan 11, 2024
Copy link
Member

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this looks good to me. I've added a few minor issues to #1162.

@lassoan
Copy link
Member

lassoan commented Jan 12, 2024

@jcfr I don't have force-push permission for this repository. Could you merge this PR, squashing this commit with @Punzo's other Visual DICOM browser commits? Thank you!

@jcfr
Copy link
Member

jcfr commented Jan 12, 2024

I will take of this in the coming hour 👌

@lassoan
Copy link
Member

lassoan commented Jan 12, 2024

Great, thank you!

@jcfr
Copy link
Member

jcfr commented Jan 12, 2024

Closing. Superseded by #1165

@jcfr jcfr closed this Jan 12, 2024
@Punzo Punzo deleted the VisualDICOMBrowserENH1 branch January 16, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants