Ensure virtual functions can be called from derived ctkVTK view pimpl #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
changed the title
jcfr
force-pushed
the
ensure-slice-render-views-virtual-functions-called-during-pimpl-init
branch
from
bc7d4e5
to
2ddd76b
Compare
…pimpl Add protected constructor to ctkVTKRenderView and ctkVTKSliceView for associating a derived pimpl. This is required to have the complete virtual function chain executed when virtual function are called in the pimpl init() function.
jcfr
force-pushed
the
ensure-slice-render-views-virtual-functions-called-during-pimpl-init
branch
from
2ddd76b
to
a330e66
Compare
jcfr
deleted the
ensure-slice-render-views-virtual-functions-called-during-pimpl-init
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add protected constructor to
ctkVTKRenderViewandctkVTKSliceViewfor associating a derived pimpl.This is required to have the complete virtual function chain executed when virtual function are called in the pimpl
init()function.Notes
While I confirmed that building Slicer against this change did not require any additional changes, it will be needed to move forward with the integration of
ENH: Allow virtual func to be called during MRML(ThreeD|Slice)View pimpl1Footnotes
https://github.com/Slicer/Slicer/pull/7311/commits/dca4f5dd541c5320ba5900f1a6c034c4cd19ee02 ↩