Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
COMP: Ensure DICOMWidget compatibility with Qt 5.12.8
This commit resolves compilation issues encountered when building the DICOMWidget against Qt 5.12.8. The changes include: 1. Removed the setting of the unsupported and unused `placeholderText` property from `ctkDICOMVisualBrowserWidget.ui`. This property's removal does not affect widget rendering. The removal addresses a compilation error introduced in commit 88ff72b ("ENH: Add Visual DICOM Browser (#1165)", 2024-01-19): ``` /path/to/CTK/Libs/DICOM/Core/ctkDICOMStorageListener.cpp:71:18: error: ‘acceptAssociations’ is not a member of ‘DcmSCP’ 71 | return DcmSCP::acceptAssociations(); | ^~~~~~~~~~~~~~~~~~ ``` 2. Introduced conditional utilization of `Qt::MatchRegularExpression`, available in Qt 5.15, to resolve a compilation error introduced in commit 888cdd9 ("ENH: Add ctkDICOMJobListWidget for logging jobs activity in the UI", 2024-01-18): ``` /path/to/CTK/Libs/DICOM/Widgets/ctkDICOMJobListWidget.cpp:405:69: error: ‘MatchRegularExpression’ is not a member of ‘Qt’ 405 | QList<QStandardItem*> list = this->findItems(tr("completed"), Qt::MatchRegularExpression, Columns::Status); | ^~~~~~~~~~~~~~~~~~~~~~ ```
- Loading branch information