This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Fix #88 in orig repo about creating recursive symlink for .fai file #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…symlink for .fai file
|
LGTM, though why hasn't Travis chimed in? @portah any thoughts on the fix? |
|
I'm not quite sure that it was a bug in CWL, the .fai was commented out I think because that samtools version worked differently. Is that fix for the same samtools docker version? About travis - travis is just syntax but not an actual run, it does not create any outputs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #88