This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
simplify hello.cwl #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first encounter with the cwl for executing something needs to be as simple as ... donno ... something really simple. The traditional "Hello world!" for instance does not need any input. It is a mere generator. When executing the cwltool, I was asked if I wanted to to run #echocmd or #main. So, if #main is obsolete, which is good, then I strongly suggest not to have it with hello. With a bit of an imagination the CommandLineTool is a special kind of workflow, i.e. one that cannot nest or interconnect other workflows but wraps a tool. Then it is just fine to execute it direcly. The input line should not be required for a command line. A missing such should just be interpreted as 'no inputs'. I also removed the "stdout" line to make it more interactive, i.e. just like the original.
smoe
added a commit
to smoe/cwltool
that referenced
this pull request
Feb 16, 2016
A consequence of observations on the simplified hello.cwl and common-workflow-library/legacy#60 .
|
Hello @smoe , thank you for this PR. I agree that one's first introduction should be simple. Have you seen @tetron 's new user guide? http://www.commonwl.org/draft-3/UserGuide.html We could probably delete the 'hello' workflow given this new resource. What do you think? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first encounter with the cwl for executing something needs to be as simple as ... donno ... something really simple. The traditional "Hello world!" for instance does not need any input. It is a mere generator.
When executing the cwltool, I was asked if I wanted to to run #echocmd or #main. So, if #main is obsolete, which is good, then I strongly suggest not to have it with hello. With a bit of an imagination the CommandLineTool is a special kind of workflow, i.e. one that cannot nest or interconnect other workflows but wraps a tool. Then it is just fine to execute it direcly.
The input line should not be required for a command line. A missing such should just be interpreted as 'no inputs'.
I also removed the "stdout" line to make it more interactive, i.e. just like the original.