-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep in store locale, country and currency #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, lots of improvements 😄
I guess this fixes issue #147 ? |
@zeina-idris @plaskevich I have fixed the tests, please check the change as they are not trivial. |
Not completely. This PR only allows to configure country/currency/languages. What the issue mentions is that we should fetch this information from the API, and fallback to the configured ones when it's not available. So let's say this PR does 25% of the issue :P |
vuex-persistedstate
to keep in local storage the authentication, as well as country/language/currency.