Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove version tracker component #3620

Merged
merged 2 commits into from
Oct 4, 2024
Merged

chore: remove version tracker component #3620

merged 2 commits into from
Oct 4, 2024
+9 −99

Conversation

leventekobor
Copy link
Contributor

Summary

As part of decommissioning mc-metrics service we are removing version tracker component which was using that service
Jira ticket

@leventekobor leventekobor added the 🚧 Status: WIP Work in progress label Oct 3, 2024
@leventekobor leventekobor self-assigned this Oct 3, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 4698266

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@commercetools-frontend/application-shell Minor
@commercetools-frontend/constants Minor
@commercetools-frontend/cypress Minor
@commercetools-applications/merchant-center-template-starter-typescript Minor
@commercetools-applications/merchant-center-template-starter Minor
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Minor
@commercetools-applications/merchant-center-custom-view-template-starter Minor
@commercetools-local/playground Minor
@commercetools-local/visual-testing-app Minor
@commercetools-frontend/actions-global Minor
@commercetools-frontend/application-components Minor
@commercetools-frontend/application-config Minor
@commercetools-frontend/application-shell-connectors Minor
@commercetools-frontend/mc-html-template Minor
@commercetools-frontend/mc-scripts Minor
@commercetools-frontend/react-notifications Minor
@commercetools-frontend/sdk Minor
@commercetools-frontend/sentry Minor
@commercetools-website/components-playground Minor
@commercetools-frontend/codemod Minor
@commercetools-frontend/mc-dev-authentication Minor
@commercetools-frontend/permissions Minor
@commercetools-frontend/i18n Minor
@commercetools-frontend/l10n Minor
@commercetools-backend/eslint-config-node Minor
@commercetools-backend/express Minor
@commercetools-backend/loggers Minor
@commercetools-frontend/assets Minor
@commercetools-frontend/babel-preset-mc-app Minor
@commercetools-frontend/browser-history Minor
@commercetools-frontend/create-mc-app Minor
@commercetools-frontend/eslint-config-mc-app Minor
@commercetools-frontend/jest-preset-mc-app Minor
@commercetools-frontend/jest-stylelint-runner Minor
@commercetools-frontend/notifications Minor
@commercetools-frontend/url-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mc-app-kit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 7:48am
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 7:48am

leventekobor
leventekobor commented Oct 3, 2024
View reviewed changes
README.md
@@ -37,7 +37,7 @@ Build the application bundles
$ pnpm build

# or
$ pnpm build:bundles:watch
$ pnpm build:watch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to the rest of the changes, but build:bundles:watch did not exist in the package.json

@leventekobor leventekobor marked this pull request as ready for review October 4, 2024 07:01
@leventekobor leventekobor requested a review from a team as a code owner October 4, 2024 07:01
@leventekobor leventekobor added fe-chapter-rotation Tasks coming from frontend chapter work and removed 🚧 Status: WIP Work in progress labels Oct 4, 2024
@leventekobor leventekobor requested a review from a team October 4, 2024 07:02
tdeekens
tdeekens reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a changeset for a release.

packages/constants/src/constants.ts
@@ -181,7 +181,6 @@ export const MC_API_PROXY_TARGETS = {
MACHINE_LEARNING: 'ml',
PIM_SEARCH: 'pim-search',
ORDER_SEARCH: 'order-search',
MC_METRICS: 'mc-metrics',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: slightly unrelated change. If we'd be strict, then this was a breaking change. Did a quick search across all codebases and it doesn't seem to be used. So I think being pragmatic is fair.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I'm fine with a minor/patch version as this is considered more of an internal usage.

@leventekobor
Copy link
Contributor Author

We need a changeset for a release.

sorry forgot about that, should it be a minor change?

@tdeekens
Copy link
Contributor

tdeekens commented Oct 4, 2024

We need a changeset for a release.

sorry forgot about that, should it be a minor change?

Yes. That minor is fine.

@CarlosCortizasCT
Copy link
Contributor

@emmenko it seems the failing VRT is a usual suspect (flaky test) and actually the new output is the right one.
Since we don't have rights to approve the change in Percy, could someone from Shield take care of it? 🙏

@leventekobor
Copy link
Contributor Author

We need a changeset for a release.

sorry forgot about that, should it be a minor change?

Yes. That minor is fine.

commit with changeset: 4698266

emmenko
emmenko approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CarlosCortizasCT
CarlosCortizasCT approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks Levent 👏

@leventekobor leventekobor merged commit e27a447 into main Oct 4, 2024
19 checks passed
@leventekobor leventekobor deleted the FEC-76-remove-version-tracker-component branch October 4, 2024 10:01
@ct-changesets ct-changesets bot mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmenko emmenko emmenko approved these changes

@tdeekens tdeekens tdeekens approved these changes

@CarlosCortizasCT CarlosCortizasCT CarlosCortizasCT approved these changes

Assignees

@leventekobor leventekobor

Labels
fe-chapter-rotation Tasks coming from frontend chapter work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leventekobor @tdeekens @CarlosCortizasCT @emmenko