Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sentry): send extra info for reported ErrorEvent #3616

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

ragafus
Copy link
Contributor

@ragafus ragafus commented Sep 27, 2024

Summary

The goal of this PR is to add more info of any ErrorEvent reported to Sentry.

The captured error message (see https://commercetools.sentry.io/issues/5880399228 as an example) is not enough to have a picture of the issue happening on production.

As an example: introducing the filename to the extra data, we will be able to understand if issues are caused by browser extensions.

Description

Copy link

changeset-bot bot commented Sep 27, 2024

🦋 Changeset detected

Latest commit: 723002a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@commercetools-frontend/sentry Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Patch
@commercetools-applications/merchant-center-custom-view-template-starter Patch
@commercetools-local/playground Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/components-playground Patch
@commercetools-frontend/cypress Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/url-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mc-app-kit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 1:04pm
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 1:04pm

@ragafus ragafus marked this pull request as ready for review September 27, 2024 13:08
@ragafus ragafus requested a review from a team as a code owner September 27, 2024 13:08
@ragafus ragafus changed the title feat: send extra info for reported ErrorEvent feat(sentry): send extra info for reported ErrorEvent Sep 27, 2024
@ragafus ragafus added the 🙏 Status: Dev Review Waiting for technical reviews label Sep 30, 2024
Copy link
Contributor

@Rhotimee Rhotimee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ragafus ragafus merged commit 545f22d into main Oct 1, 2024
19 checks passed
@ragafus ragafus deleted the rg-sentry-extra-error-event branch October 1, 2024 08:26
@ct-changesets ct-changesets bot mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 Status: Dev Review Waiting for technical reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants