Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Korean Thanksgiving Day #480

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hweejae-shin
Copy link

@hweejae-shin hweejae-shin commented Jun 28, 2024

Why Change

  • South Korea observes a holiday for the day before and the day after Chuseok.
  • However, the current data shows a three-day holiday from Chuseok itself.
  • Therefore, the data should be modified to reflect a three-day holiday starting from the day before Chuseok.

Reference

image

What Change

  • Change Korean Thanksgiving Day data
  • Update the unimplemented test code

@commenthol
Copy link
Owner

Hi @hweejae-shin,
Thanks for your PR. Can you please check why the tests are failing?
Please consider updating the fixtures with (See CONTRIBUTING.md):

npx mocha test/all.mocha.js --writetests --countries HK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants