Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed CL Indigenous People's Day from fixed date june 21st to june solstice #479

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

CrisBerriosL
Copy link

@CrisBerriosL CrisBerriosL commented Jun 11, 2024

In the project there was a holiday specified for Chile as june 21st, when in reality it is for the winter solstice (southern hemisphere).
The holiday was approved in 2021, to be valid since 2022. In the year 2021, the holiday was set for june 21st in spite of that year's solstice falling on the 20th.

Made changes so the holiday is considered as june solstice in America/Santiago since 2022, and '06-21' for the year 2021.

Sources:

  • This article is the law implemented in 2021 that indicates that the holiday for "Día Nacional de los Pueblos Indígenas" is on the winter solstice in the southern hemisphere, except that year where it is set to june 21st.
  • This page has the chilean holidays for 2024 and 2025, in both cases the holiday is the 20th of june.

@CrisBerriosL CrisBerriosL reopened this Jun 11, 2024
@CrisBerriosL CrisBerriosL changed the title chore: changed CL fixed date holiday june 21st to june solstice Changed CL Indigenous People's Day from fixed date june 21st to june solstice Jun 11, 2024
@commenthol commenthol merged commit 67ae01f into commenthol:master Nov 26, 2024
6 checks passed
@commenthol
Copy link
Owner

@CrisBerriosL Thanks for your PR. I am sorry for the late merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants