Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Singapore Public Holidays 2024 #463

Merged
merged 3 commits into from
Feb 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion data/countries/SG.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,15 @@ holidays:
en: Hari Raya Haji
# Revision from SG gov
# @source https://www.humanresourcesonline.net/singapore-s-revised-public-holiday-list-for-2022-new-dates-for-hari-raya-puasa-and-haji
# https://www.mom.gov.sg/employment-practices/public-holidays
disable:
- "2022-07-09"
- "2023-06-28"
- "2024-06-29"
enable:
- "2022-07-10"
- "2023-06-29"
- "2024-06-17"
# @attrib https://en.wikipedia.org/wiki/Vesak
# date if sunday then next monday
"2001-05-07":
Expand Down Expand Up @@ -132,7 +135,8 @@ holidays:
# @source https://www.mom.gov.sg/newsroom/press-releases/2022/0929-revised-date-for-vesak-day-2023#:~:text=Revised%20Date%20for%20Vesak%20Day%20in%202023&text=1%20Following%20the%20Singapore%20Buddhist,public%20holiday%20for%20Vesak%20Day .
"2023-06-02":
_name: Vesak
"2024-05-23":
# https://www.mom.gov.sg/employment-practices/public-holidays
"2024-05-22":
_name: Vesak
# Deepavali
# date if sunday then next monday
Expand Down
10 changes: 5 additions & 5 deletions test/fixtures/SG-2024.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@
"_weekday": "Wed"
},
{
"date": "2024-05-23 00:00:00",
"start": "2024-05-22T16:00:00.000Z",
"end": "2024-05-23T16:00:00.000Z",
"date": "2024-05-22 00:00:00",
"start": "2024-05-21T16:00:00.000Z",
"end": "2024-05-22T16:00:00.000Z",
"name": "Vesak Day",
"type": "public",
"rule": "2024-05-23",
"_weekday": "Thu"
"rule": "2024-05-22",
"_weekday": "Wed"
},
{
"date": "2024-06-16 00:00:00 -0600",
Expand Down
Loading