-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have github actions automatically push PR autofixes #3528
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how exactly this work or why there is this message "please use git push -f", but if you need --force
please use --force-with-lease
, making following a branch easier. Why do we encourage to force push at all? I always communicate the opposite, since it makes reviewing PRs much harded and GitHub UI looses all personal review state and I have to start over. Also, a lightly git push -f
risks to loose commits made by other maintainers.
buildcmd: | | ||
set -eux; | ||
git fetch --unshallow; | ||
git commit --allow-empty -am 'Github Actions Autofix; please use "git push -f" next time you push to this PR'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git commit --allow-empty -am 'Github Actions Autofix; please use "git push -f" next time you push to this PR'; | |
git commit --allow-empty -am 'Github Actions Autofix; please use "git push --force-with-lease" next time you push to this PR'; |
|
I have a alias
|
This will save the tedious process of noticing formatting/scalafix irregularities and having to run a manual command before pushing them.