Clear locks using reserve_sql_strategy
#211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When shutting down and releasing jobs, we should still respect the `ActiveRecord.configuration.reserve_sql_strategy` and clear locks using explicit job ids if the strategy is `:default_sql`. This can help avoid transaction isolation conflicts when shutting down several job runners.
|
If locked_by is hitting a conflict you have misconfigured something and will have major issues with duplicate job runs. |
|
It's not so much that locked_by is causing a conflict but that the non-primary key query to obtain a lock on a row uses a range lock, which must wait behind transactions that have created a job but have not committed yet. If those transactions are long running and plentiful, it can cause the delayed job shutdown process to take a long time. Therefore this change is intended to apply the same mechanism to unlocking as is used for locking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shutting down and releasing jobs, we should still respect the
ActiveRecord.configuration.reserve_sql_strategyand clear locks using explicit job ids if the strategy is:default_sql. This can help avoid transaction isolation conflicts when shutting down several job runners.