-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XML Sending and custom field mapping #52
Open
JeffersonBledsoe
wants to merge
15
commits into
main
Choose a base branch
from
send-xml
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiberiuichim
approved these changes
Nov 28, 2022
JeffersonBledsoe
changed the title
XML Sending and custom field mapping
WIP: XML Sending and custom field mapping
Nov 28, 2022
Still a few issues with this PR (namely attachment fields break the form). I'll see if I can add some tests to check the XML behaviour :) |
JeffersonBledsoe
changed the title
WIP: XML Sending and custom field mapping
XML Sending and custom field mapping
Mar 7, 2023
Hey @pnicolli, any chance of a review on this? |
# Conflicts: # src/formSchema.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires collective/collective.volto.formsupport#22
This PR adds supports for attaching an XML file containing the data submitted in the form to the email. This feature is available in collective.easyform and may be useful to those transitioning to Volto. To further help transition collective.easyform users who may be reliant on specific field IDs when using collective.easyform, the ability to customise the label for sending/ downloading XML and CSV was also added.
The below video demonstrates the custom value mapping when downloading the CSV file. The XML after the video was the contents of the file attached to the email sent when submitting the form.
Screen.Recording.2022-11-23.at.7.33.22.pm.mov