Authomatic can be set roles after login

[bsuttor]

Hello,

I would like to be able to set roles to a user connected through PAS provider plugin.

So I implemented IRolesPlugin (from Products.PluggableAuthService.interfaces.plugins) in this package and use _x_user_parser method to get roles in a provider:

def _x_user_parser(user, data):
    [...]
    roles = data.get('roles', [])
    if roles:
        user.roles = roles
    return user

Do you think It's good way to do that, and do you think you can merge it into pas.plugins.authomatic ?

I didn't add test for one simple reason, I don't know best way to do that.
Can I add a test in test_plugin.py file ?
So I'm going to change test layer (replace PAS_PLUGINS_Authomatic_ZOPE_FIXTURE by PAS_PLUGINS_Authomatic_PLONE_FIXTURE) ?
How can I add roles params to user ?

[cekk]

I'm interested in this feature too. At least to add "Member" role.
@jensens what do you think about it?

[jensens]

Well, I am not sure if we need to deal with roles in here. But if we do, I would like to see some basic tests and good documentation.