Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-band unscaling works with indexes #709

Closed
wants to merge 1 commit into from

Conversation

jddeal
Copy link

@jddeal jddeal commented May 17, 2024

This updates the per-band unscaling to support when indexes=[...] are passed. I didn't account for that in the PR a couple days ago, sorry about that!

Fortunately a quick fix to select from the scales/offsets arrays so that they continue to match the shape of the image data. I've been testing this with files we make containing dozens of bands with different (or no) scale/offset rules and I haven't noticed any issues with mismatching or incorrect shapes.

You also should be able to edit this forked repo now. Not sure what I'm missing in the settings, but it is part of my work org and maybe there's something I can't see getting in the way by default. I added you with write permission on the repo to hopefully get around that.

@vincentsarago
Copy link
Member

oohhh thanks for catching this 😅 🙏

@vincentsarago
Copy link
Member

BTW @jddeal I don't need to be added to aerisweather/rio-tiler repo. Usually when creating a PR from fork you can allow maintainers to push directly in the fork https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@vincentsarago vincentsarago mentioned this pull request May 17, 2024
@vincentsarago
Copy link
Member

finished in #710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants