Set button text size to button font size automatically; make line height automatically scale based on font size #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with font size changes
…o longer change LineHeight based on FontSize setting since it is now relative to Font.Size, which already changes
…andled and does make sense This reverts commit f10f995.
rcoreilly
approved these changes
Nov 25, 2024
This was referenced Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the text element of a button automatically have the font size of the button itself, which makes it much easier to customize. It also makes line height expressed in terms of em instead of dp, which makes it automatically scale based on font size and thus removes the need for manually changing line height when changing font size. I will document this behavior on the website within the next few days.
Fixes #1313 and fixes #1150