More Cogent Mail updates #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CacheMessagesForMailbox; should fix issue where it resets the entire cache once it gets to another mailbox
…t issues with modifying a.readMessage.Labels while looping over it and checking it
…Labels saving; labeling now fully working
…er mail clients correctly
…s; improve cache file saving safety in mail
…or conversation threading
…h new conversationStart function
…y most recent date instead of first date
… any of its replies are unread
rcoreilly
reviewed
Oct 9, 2024
| @@ -92,108 +108,164 @@ func (a *App) CacheMessages() error { | |||
| // CacheMessages caches all of the messages from the server that | |||
| return fmt.Errorf("authenticating: %w", err) | ||
| var err error | ||
| c := a.imapClient[email] | ||
| if c == nil { |
There was a problem hiding this comment.
this should not be an if statement buried within the cache logic.
| } | ||
| alreadyHaveSlice := []imap.UID{} | ||
| alreadyHaveMap := map[imap.UID]bool{} | ||
| for _, cm := range cached { |
There was a problem hiding this comment.
this should be a separate func -- used at least 2x
| // other given values, using an iterative batched approach that fetches the | ||
| // five next most recent messages at a time, allowing for concurrent mail | ||
| // modifiation operations and correct ordering. | ||
| func (a *App) CacheUIDs(uids []imap.UID, c *imapclient.Client, email string, mailbox string, dir string, cached map[string]*CacheData, cacheFile string) error { | ||
| func (a *App) cacheUIDs(uids []imap.UID, c *imapclient.Client, email string, mailbox string, dir string, cached map[string]*CacheMessage) error { |
There was a problem hiding this comment.
this is a deeply nested long function -- consider useful subroutines or other logical structure.
rcoreilly
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More improvements and features for Cogent Mail that get it almost ready for dogfooding, although not quite yet. Includes attachments and better labeling and caching support.