Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add search command #99

Merged
merged 3 commits into from
Jul 29, 2023
Merged

feat(core): add search command #99

merged 3 commits into from
Jul 29, 2023

Conversation

tareknaser
Copy link
Collaborator

fixes #98

@netlify
Copy link

netlify bot commented Apr 14, 2023 •
edited
Loading

✅ Deploy Preview for coffee-docs ready!

Name Link
🔨 Latest commit de52027
🔍 Latest deploy log https://app.netlify.com/sites/coffee-docs/deploys/64c54bc8b672b600089e8aff
😎 Deploy Preview https://deploy-preview-99--coffee-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vincenzopalazzo
vincenzopalazzo requested changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments

coffee_cmd/src/main.rs Outdated Show resolved Hide resolved
coffee_core/src/coffee.rs Outdated Show resolved Hide resolved
coffee_cmd/src/main.rs Outdated Show resolved Hide resolved
vincenzopalazzo
vincenzopalazzo requested changes Apr 14, 2023
View reviewed changes
coffee_cmd/src/main.rs Outdated Show resolved Hide resolved
coffee_cmd/src/main.rs Outdated Show resolved Hide resolved
coffee_core/src/coffee.rs Outdated Show resolved Hide resolved
coffee_core/src/coffee.rs Outdated Show resolved Hide resolved
docs/docs-book/src/using-coffee.md Outdated Show resolved Hide resolved
coffee_cmd/src/main.rs Outdated Show resolved Hide resolved
coffee_cmd/src/main.rs Outdated Show resolved Hide resolved
@tareknaser tareknaser force-pushed the search branch 2 times, most recently from 7b75044 to a4e72b9 Compare April 15, 2023 12:21
vincenzopalazzo
vincenzopalazzo requested changes Apr 15, 2023
View reviewed changes
coffee_core/src/coffee.rs Outdated Show resolved Hide resolved
vincenzopalazzo
vincenzopalazzo reviewed Apr 15, 2023
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the code looks good, but now lets talk about the meaning of this command, I am not sure that this command make sense

coffee_lib/src/plugin_manager.rs Outdated Show resolved Hide resolved
@vincenzopalazzo vincenzopalazzo added 💭 - brainstorming feature idea and related discussion ❤️ - RFC Request for Comments, it is under consideration labels Apr 16, 2023
@vincenzopalazzo vincenzopalazzo self-assigned this Apr 16, 2023
@tareknaser tareknaser marked this pull request as draft July 29, 2023 04:49
@tareknaser tareknaser marked this pull request as ready for review July 29, 2023 17:27
vincenzopalazzo
vincenzopalazzo approved these changes Jul 29, 2023
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@vincenzopalazzo vincenzopalazzo merged commit 3784046 into coffee-tools:master Jul 29, 2023
9 checks passed
@tareknaser tareknaser deleted the search branch July 29, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees

@vincenzopalazzo vincenzopalazzo

Labels
💭 - brainstorming feature idea and related discussion ❤️ - RFC Request for Comments, it is under consideration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

search command
2 participants
@tareknaser @vincenzopalazzo