Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmd): change table label #272

Conversation

Anyitechs
Copy link

This PR addresses @tareknaser and @vincenzopalazzo suggestion in #239 (comment)

Closes #268

@vincenzopalazzo
Copy link
Contributor

Coffee has the best documentation that I ever written, please read the commit style https://coffee-docs.netlify.app/contributing-to-coffee

Copy link
Collaborator

@tareknaser tareknaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

coffee_cmd/src/coffee_term/command_show.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing is hard in coding, and it is naming things 😄

After that ping me and we merge the PR

@@ -97,7 +97,7 @@ pub fn show_nurse_verify(nurse_verify: &ChainOfResponsibilityStatus) -> Result<(
table.push([
term::format::dim(String::from("●")),
term::format::bold(String::from("Defects")),
term::format::bold(String::from("Affected repositories")),
term::format::bold(String::from("Action")),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
term::format::bold(String::from("Action")),
term::format::bold(String::from("Affected")),

thanks @tareknaser for the suggestion

@Anyitechs Anyitechs changed the title chore(change-table-label): change table label from "Affected repositories" to "Action" chore(cmd): change table label Apr 18, 2024
@Anyitechs
Copy link
Author

Coffee has the best documentation that I ever written, please read the commit style https://coffee-docs.netlify.app/contributing-to-coffee

Thank you @vincenzopalazzo for sharing the link. Recent commits are following the style guide now.

@vincenzopalazzo vincenzopalazzo merged commit 8615159 into coffee-tools:macros/moving-repository-dir May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants