-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git: adding basic function to checkout a branch #248
Draft
vincenzopalazzo
wants to merge
4
commits into
master
Choose a base branch
from
macros/git-checkout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
63ca832
git: adding basic function to checkout a branch
vincenzopalazzo 8170661
cli: pass down the cli the branch arg
vincenzopalazzo 6173c22
core: allow to install a branch
vincenzopalazzo 4d7920d
fixup! core: allow to install a branch
vincenzopalazzo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
//! Github repository implementation | ||
|
||
pub mod repository; | ||
mod utils; | ||
pub mod utils; | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,10 @@ | ||
use log::debug; | ||
use tokio::process::Command; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wrong import place |
||
|
||
use coffee_lib::errors::CoffeeError; | ||
use coffee_lib::macros::error; | ||
use coffee_lib::url::URL; | ||
use coffee_lib::{commit_id, get_repo_info, sh}; | ||
use log::debug; | ||
|
||
use coffee_lib::types::response::UpgradeStatus; | ||
|
||
|
@@ -30,8 +32,6 @@ pub async fn git_upgrade( | |
branch: &str, | ||
verbose: bool, | ||
) -> Result<UpgradeStatus, CoffeeError> { | ||
use tokio::process::Command; | ||
|
||
let repo = git2::Repository::open(path).map_err(|err| error!("{}", err.message()))?; | ||
|
||
let (local_commit, _) = get_repo_info!(repo); | ||
|
@@ -48,3 +48,19 @@ pub async fn git_upgrade( | |
Ok(UpgradeStatus::Updated(upstream_commit, date)) | ||
} | ||
} | ||
|
||
pub async fn git_checkout( | ||
path: &str, | ||
branch: &str, | ||
verbose: bool, | ||
) -> Result<(String, String), CoffeeError> { | ||
let mut cmd = format!("git fetch origin\n"); | ||
cmd += &format!("git reset --hard\n"); | ||
cmd += &format!("git checkout origin/{branch}"); | ||
sh!(path, cmd, verbose); | ||
|
||
let repo = git2::Repository::open(path).map_err(|err| error!("{}", err.message()))?; | ||
let (upstream_commit, date) = get_repo_info!(repo); | ||
|
||
Ok((upstream_commit, date)) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We switch the whole repository to the required branch but we don't switch back to the original branch of the repository after installing the plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice point