coffee: fix the upgrade commands #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for coffee-docs canceled.
|
vincenzopalazzo
force-pushed
the
macros/upgrade-command-fix
branch
from
521be72
to
13df654
Compare
vincenzopalazzo
changed the title
tareknaser
suggested changes
Feb 5, 2024
There was a problem hiding this comment.
Great job!
Left some comments.
Let's also remove this function because coffee upgrade should upgrade a whole repository not a single plugin as per our discussion
vincenzopalazzo
force-pushed
the
macros/upgrade-command-fix
branch
from
dc1426f
to
7cf909e
Compare
tareknaser
approved these changes
Feb 5, 2024
This commit introduce a basic refactoring that remove the libgit2 solution to upgrade a repository and use the pure git command. Currently we are using git in other places, and it should be fine to use it there. To keep faith in our contribution guide line, we should implement the simple things that works, without implementing a complex things that did not work. At some point when coffee is stable we can thing to remove the git command usage and use a pure git library. Changelog-Fixed: git: remove the libgit2 upgrade commands and use a raw git command Signed-off-by: Vincenzo Palazzo <[email protected]>
This semplify the code to report the upgrade status by storing the commit information inside the enum itself. Changelog-Added: lib: store the commit information inside the enum Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
This commit pass down the verbose running information down to the upgrade method of the repository. Changelog-Added: lib: accept the verbose flag during upgrading Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/upgrade-command-fix
branch
from
d276cf5
to
fc0fc54
Compare
Signed-off-by: Vincenzo Palazzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was on a plane and I found the time to write a PoC for better upgrade commands, this also introduced a simplification of the code
Fixes #223
Fixes #214