Redesign of the nurse command #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
added
the
❤️ - RFC
✅ Deploy Preview for coffee-docs canceled.
|
tareknaser
reviewed
Jul 29, 2023
Comment on lines
+6
to
+21
| //! >The basic idea behind the Strategy pattern is that, given an | ||
| //! > algorithm solving a particular problem, we define only | ||
| //! > the skeleton of the algorithm at an abstract level, and we | ||
| //! > separate the specific algorithm’s implementation into | ||
| //! > different parts. | ||
| //! > | ||
| //! > In this way, a client using the algorithm may choose | ||
| //! > a specific implementation, while the general algorithm | ||
| //! > workflow remains the same. In other words, the abstract | ||
| //! > specification of the class does not depend on the specific | ||
| //! > implementation of the derived class, but specific implementation | ||
| //! > must adhere to the abstract specification. | ||
| //! | ||
| //! So in this specific case the nurse command may need | ||
| //! different kind of recovery algorithm, so we should | ||
| //! be able to choose the algorithm at runtime. |
There was a problem hiding this comment.
Thanks for the explanation
Yeah I will leave this to you now, let me fix the review and we merge it as a draft |
vincenzopalazzo
force-pushed
the
macros/nurse-logic
branch
2 times, most recently
from
0be7404
to
44090d1
Compare
This commit introduce a basic architecture to run the nurse command by using two design pattern, that are the chain of responsability for choosing what kind of strategy apply, and a strategy pattern to abstract the algorithm under a basic view. Signed-off-by: Vincenzo Palazzo <[email protected]> feat(core): add nurse chain of responsability to select the recovery algorithm Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/nurse-logic
branch
from
44090d1
to
bad8427
Compare
|
Merging this and leaving it to play with to @tareknaser360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review each commit by review also the comments of the module.