-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blocks-api): blocks.update() now can update tunes
as well as data
#2720
feat(blocks-api): blocks.update() now can update tunes
as well as data
#2720
Conversation
AFAIK, when you update block using `editor.blocks.update` method, only `data` attribute is merged and updated. I believe `tunes` data should be updated if provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add a corresponded testcase
Update `tunes` data when new `tunes` data is provided
I have added a test. In order to prevent breaking change, I decided to add new parameter called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready to approve, please check the last comment and add a changelog
tunes
data when new tunes
data is providedtunes
as well as data
AFAIK, when you update block using
editor.blocks.update
method, onlydata
attribute is merged and updated. I believetunes
data should be updated if provided.