-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/add tunes data in mutation events #2686
Open
GuillaumeOnepilot
wants to merge
10
commits into
codex-team:next
Choose a base branch
from
OnepilotHQ:fix/add-tunes-data-in-mutation-events
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/add tunes data in mutation events #2686
GuillaumeOnepilot
wants to merge
10
commits into
codex-team:next
from
OnepilotHQ:fix/add-tunes-data-in-mutation-events
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeOnepilot
requested review from
neSpecc,
gohabereg,
TatianaFomina and
ilyamore88
as code owners
April 15, 2024 19:54
Could you provide some examples? |
So basically I want my tune to act a some kind of metadata on the blocks, but the events don't hold the tune's data and I don't use the saver api in my case. Screen.Recording.2024-04-16.at.08.22.23.mov |
Why not just call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My usage of EditorJs rely mainly on the Mutation events to make granular actions on my backend, instead of pushing the whole lists of blocks.
I'm currently working on an annotation feature which require the tunes data to be sent, but unfortunately the different events don't have the tunes data sent with them, which mean I have to change my logic (which would be complicated)
So I propose to add the tunes data inside the different mutations events.