Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use updated astring generator #7928

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

barelyhuman
Copy link

@barelyhuman barelyhuman commented Aug 10, 2023

What kind of change does this PR introduce?

Enhancement / Fix

What is the current behavior?

JSXFragment, JSXSpreadAttributes will not be rendered properly

What is the new behavior?

Handles the above with added code in the original library

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

N/A

Checklist

  • Documentation - N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

Waiting on the instruction, to do the above if the team still uses the babel transpiler and is not already handling the above mentioned Tokens elsewhere

@codesandbox
Copy link

codesandbox bot commented Aug 10, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 134b07d:

Sandbox Source
Notifications Test Configuration

@CompuIves
Copy link
Member

Hey! Thanks for the contribution, do you have an example where we're currently not parsing/rendering this correctly?

@barelyhuman
Copy link
Author

Not sure, I didn't go through the entire codebase but the reason for update was the missing JSXEmptyExpression and JSXFragment writers missing in the original code which was derived from v0.1.x of astring-jsx which hasn't been updated with the new additions in acorn-jsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants