-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footerupdate #1945
Footerupdate #1945
Conversation
@Priyal208 is attempting to deploy a commit to the Vivek Prajapati's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent changes enhance the layout of the footer in the web application. By introducing a vertical shift of 20 pixels to both the footer and a Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/User/components/Footer/Footer.css (2 hunks)
- src/User/pages/Home/Home.jsx (1 hunks)
Files skipped from review due to trivial changes (1)
- src/User/components/Footer/Footer.css
Additional comments not posted (1)
src/User/pages/Home/Home.jsx (1)
142-144
: Confirm the purpose and impact of the inline style change.The addition of the
transform: translateY(20px)
property shifts thediv
element vertically by 20 pixels. Ensure this change effectively resolves the footer overflow issue and does not introduce any layout issues on different screen sizes.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Fixes Issue
Fixes #1829
Close #1829
Changes proposed
The footer overflowed vertically I adjust and translated footer and above components appropriated so that white space at bottom is eliminated , as well as made sure that it responsive also
Screenshots
349551119-01a5e19b-4469-436f-94cc-e4ec2f3f53d1.mp4
Note to reviewers
Earlier I created PR for this same issue but it had conflicts, now this PR has no conflicts, i created new branch and re-do my changes, previous close PR for your refernce #1880
Summary by CodeRabbit
New Features
Bug Fixes