Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order Total Bug Fixed #1933

Closed
wants to merge 2 commits into from
Closed

Order Total Bug Fixed #1933

wants to merge 2 commits into from

Conversation

K-kiran77
Copy link

@K-kiran77 K-kiran77 commented Jul 21, 2024 •
edited by coderabbitai bot
Loading

Fixes Issue

My issue number is #1926
Closes #1926

Changes proposed

Previously even there are no items in the cart the total amount was showing $40.00, Now i made change in the ordersummary component to show $0.00 when no items in the cart and total value including delivery charge when items in the cart

Screenshots

orderCart

Note to reviewers

Summary by CodeRabbit

  • Bug Fixes
    • Updated the display logic in the Order Summary to conditionally show the total amount based on order value.
    • Note: The total amount is now hardcoded as $0.00, which may mislead users about their actual order total.

@vercel Vercel
Copy link

vercel bot commented Jul 21, 2024

@K-kiran77 is attempting to deploy a commit to the Vivek Prajapati's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 21, 2024 •
edited
Loading

Walkthrough

The recent changes to the OrderSummary component resolve a bug where the order total erroneously displayed a static amount of $40 when the cart was empty. The update ensures that the total correctly shows as $0.00 when there are no items, improving user experience by providing accurate total amounts based on actual cart contents.

Changes

Files Change Summary
src/User/components/Order/OrderSummary.jsx Modified the total display logic to show $0.00 when the cart is empty, correcting previous misleading information.

Assessment against linked issues

Objective Addressed Explanation
Set total to $0 when no items in the cart (#1926) ✅
Display total amount including shipping when items are present ❌ The update does not calculate or display the total amount dynamically, ignoring shipping costs.

Hop hop hooray, with totals now bright,
A zero displays when the cart's light!
No more confusion, just clarity's cheer,
For happy little bunnies shopping here! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 21, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 912c54a and 4e5539c.

Files selected for processing (1)
  • src/User/components/Order/OrderSummary.jsx (1 hunks)
Additional comments not posted (2)
src/User/components/Order/OrderSummary.jsx (2)

43-43: LGTM! Ensure dynamic calculation for non-empty carts.

The change correctly displays $0.00 when the cart is empty.

Verify that the dynamic calculation is still in place for non-empty carts.

Line range hint 59-59:
Dynamic calculation is correct.

The dynamic calculation of the total amount when there are items in the cart is correct and aligns with the PR objectives.

@codervivek5
Copy link
Owner

pull the code again and make make price to rupee instead of dollar

@codervivek5
Copy link
Owner

and also fix when the total is below 500 then add shipping 40 and if the price will greater then 500 then make shipping free.

coderabbitai[bot]
coderabbitai bot reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4e5539c and 2027848.

Files selected for processing (1)
  • src/User/components/Order/OrderSummary.jsx (2 hunks)
Additional comments not posted (2)
src/User/components/Order/OrderSummary.jsx (2)

43-43: LGTM!

The code correctly displays 0.00 when there are no items in the cart.

Line range hint 69-69:
LGTM!

The code correctly formats and displays the total amount.

src/User/components/Order/OrderSummary.jsx Show resolved Hide resolved
@K-kiran77
Copy link
Author

Kindly review the latest commit, Shipping charges for cart greater than 500 are made free and for less than 500 charges are added and also changed the currency to rupees

Here are the screenshots

vigy1
vigy2
vigy3

@vercel Vercel
Copy link

vercel bot commented Jul 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vigybag ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 6:32pm

@codervivek5 codervivek5 assigned K-kiran77 and unassigned K-kiran77 Jul 26, 2024
@codervivek5
Copy link
Owner

I think this issue is already fixed ?

@codervivek5
Copy link
Owner

This issue is fixed

@codervivek5 codervivek5 closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai coderabbitai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG:Order total is still 40rs even no items in the cart
2 participants
@K-kiran77 @codervivek5