-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve guides #185
Draft
CarlosHSF99
wants to merge
5
commits into
main
Choose a base branch
from
cf/improve-guides
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosHSF99
requested review from
nelsonmestevao,
danielsp45,
ruilopesm and
MarioRodrigues10
June 26, 2023 13:10
✅ Deploy Preview for coderdojobraga-blog ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for coderdojobraga-app canceled.
|
✅ Deploy Preview for coderdojobraga-web canceled.
|
✅ Deploy Preview for coderdojobraga-maintenance canceled.
|
I would love to see this PR finished 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing CONTRIBUTING guide was moved to apps/blog as it mainly focus on writing for the blog. But, I'm not sure if it makes sense to have a CONTRIBUTING.md there as it won't be recognized by GitHub as such and there's not much more to write in the blog's README so maybe it should just all be there.
The README "logo" is there just as a placeholder, but it might just removed.
At the moment, the "Delevoping" section is both in the root README and CONTRIBUTING files as I'm not sure where it should be.