add declare(strict_types=1)

codeigniter4 · Aug 16, 2023 · 213cddd · 213cddd
1 parent 1e8e2d6
commit 213cddd
Show file tree

Hide file tree

Showing 28 changed files with 62 additions and 8 deletions.
diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use CodeIgniter\CodingStandard\CodeIgniter4;
 use Nexus\CsConfig\Factory;
 use PhpCsFixer\Finder;

diff --git a/src/Commands/Disable.php b/src/Commands/Disable.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks\Commands;
 
 use CodeIgniter\CLI\CLI;

diff --git a/src/Commands/Enable.php b/src/Commands/Enable.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks\Commands;
 
 use CodeIgniter\CLI\CLI;

diff --git a/src/Commands/Lister.php b/src/Commands/Lister.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks\Commands;
 
 use CodeIgniter\CLI\CLI;

diff --git a/src/Commands/Run.php b/src/Commands/Run.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks\Commands;
 
 use CodeIgniter\CLI\CLI;

diff --git a/src/Commands/TaskCommand.php b/src/Commands/TaskCommand.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks\Commands;
 
 use CodeIgniter\CLI\BaseCommand;

diff --git a/src/Config/Services.php b/src/Config/Services.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks\Config;
 
 use CodeIgniter\Tasks\CronExpression;

diff --git a/src/Config/Tasks.php b/src/Config/Tasks.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks\Config;
 
 use CodeIgniter\Config\BaseConfig;

diff --git a/src/CronExpression.php b/src/CronExpression.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks;
 
 use CodeIgniter\I18n\Time;

diff --git a/src/Exceptions/TasksException.php b/src/Exceptions/TasksException.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks\Exceptions;
 
 use RuntimeException;

diff --git a/src/FrequenciesTrait.php b/src/FrequenciesTrait.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks;
 
 /**
@@ -25,8 +27,6 @@ trait FrequenciesTrait
     /**
      * If listed, will restrict this to running
      * within only those environments.
-     *
-     * @var null
      */
     protected $allowedEnvironments;
 

diff --git a/src/Language/en/Tasks.php b/src/Language/en/Tasks.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'invalidTaskType'       => '"{0}" is not a valid type of task.',
     'invalidCronExpression' => '"{0}" is not a valid cron expression.',

diff --git a/src/RunResolver.php b/src/RunResolver.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks;
 
 use CodeIgniter\I18n\Time;

diff --git a/src/Scheduler.php b/src/Scheduler.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks;
 
 use Closure;

diff --git a/src/Task.php b/src/Task.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks;
 
 use CodeIgniter\Events\Events;

diff --git a/src/TaskLog.php b/src/TaskLog.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks;
 
 use CodeIgniter\I18n\Time;

diff --git a/src/TaskRunner.php b/src/TaskRunner.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks;
 
 use CodeIgniter\CLI\CLI;

diff --git a/src/Test/MockScheduler.php b/src/Test/MockScheduler.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks\Test;
 
 use CodeIgniter\Tasks\Scheduler;

diff --git a/src/Test/MockTask.php b/src/Test/MockTask.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks\Test;
 
 use CodeIgniter\Tasks\Exceptions\TasksException;

diff --git a/tests/_support/Commands/TasksTest.php b/tests/_support/Commands/TasksTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Tests\Support\Commands;
 
 use CodeIgniter\CLI\BaseCommand;

diff --git a/tests/_support/TasksTestCase.php b/tests/_support/TasksTestCase.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Tests\Support;
 
 use CodeIgniter\Test\CIUnitTestCase;

diff --git a/tests/mock/MockTest.php b/tests/mock/MockTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace CodeIgniter\Tasks\Test;
 
 use Tests\Support\TasksTestCase;

diff --git a/tests/unit/CronExpressionTest.php b/tests/unit/CronExpressionTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use CodeIgniter\I18n\Time;
 use CodeIgniter\Tasks\CronExpression;
 use CodeIgniter\Tasks\Exceptions\TasksException;
@@ -129,7 +131,7 @@ public function testHoursAndMins()
     }
 
     /**
-     * @dataProvider hoursProvider
+     * @dataProvider provideEveryHour
      *
      * @param mixed $hourTrue
      * @param mixed $hourFalse
@@ -181,7 +183,7 @@ public function testEveryWeekdayInMonth()
         $this->assertFalse($this->cron->shouldRun('0 20 * 10 1-5'));
     }
 
-    public function hoursProvider()
+    public static function provideEveryHour(): iterable
     {
         $hours24 = array_map(static fn ($h) => [
             $h . ':00',
@@ -199,7 +201,7 @@ public function hoursProvider()
         return [...$hours24, ...$hoursAM, ...$hoursPM];
     }
 
-    public function nextRunProvider()
+    public static function provideNextRun(): iterable
     {
         return [
             ['* * * * *', 'October 5, 2020 8:01 pm'],
@@ -224,7 +226,7 @@ public function nextRunProvider()
     }
 
     /**
-     * @dataProvider nextRunProvider
+     * @dataProvider provideNextRun
      */
     public function testNextRun(string $exp, string $expected)
     {

diff --git a/tests/unit/FrequenciesTraitTest.php b/tests/unit/FrequenciesTraitTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use CodeIgniter\Tasks\FrequenciesTrait;
 use CodeIgniter\Test\CIUnitTestCase as TestCase;
 

diff --git a/tests/unit/SchedulerTest.php b/tests/unit/SchedulerTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use CodeIgniter\Tasks\Scheduler;
 use CodeIgniter\Tasks\Task;
 use CodeIgniter\Test\CIUnitTestCase as TestCase;

diff --git a/tests/unit/TaskLogTest.php b/tests/unit/TaskLogTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use CodeIgniter\I18n\Time;
 use CodeIgniter\Tasks\Task;
 use CodeIgniter\Tasks\TaskLog;
@@ -10,7 +12,7 @@
  */
 final class TaskLogTest extends TestCase
 {
-    public function durationProvider()
+    public static function provideDuration(): iterable
     {
         return [
             [
@@ -32,7 +34,7 @@ public function durationProvider()
     }
 
     /**
-     * @dataProvider durationProvider
+     * @dataProvider provideDuration
      *
      * @param mixed $start
      * @param mixed $end

diff --git a/tests/unit/TaskRunnerTest.php b/tests/unit/TaskRunnerTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use CodeIgniter\Tasks\Task;
 use CodeIgniter\Tasks\TaskRunner;
 use CodeIgniter\Test\CIUnitTestCase as TestCase;

diff --git a/tests/unit/TaskTest.php b/tests/unit/TaskTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use CodeIgniter\I18n\Time;
 use CodeIgniter\Tasks\Task;
 use CodeIgniter\Test\DatabaseTestTrait;