Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add strict_types #21

Merged
merged 2 commits into from
Dec 18, 2023
Merged

refactor: add strict_types #21

merged 2 commits into from
Dec 18, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 17, 2023 •
edited
Loading

Needs #20

Description

  • add strict_types

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft December 17, 2023 21:50
@kenjis kenjis force-pushed the add-strict_types branch 2 times, most recently from 29bf3e0 to 90d2c47 Compare December 18, 2023 09:34
@kenjis kenjis marked this pull request as ready for review December 18, 2023 09:35
@kenjis kenjis mentioned this pull request Dec 18, 2023
Merged
1 task
@michalsn michalsn merged commit 69ed7f5 into codeigniter4:develop Dec 18, 2023
11 checks passed
@kenjis kenjis deleted the add-strict_types branch December 19, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn