Ask if violations are traffic related #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* and they need this additional question: in multnomah county if the charge is traffic related then it's considered a traffic charge * fix test cases and add a demo record for manual testing.
… an ugly question
KentShikama
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a request from Michael and team. In multnomah county they need to identify Violations and Reduced to Violations as possibly traffic-related even if OECI doesn't reflect them as such.
In my first commit I tried to avoid a major change to the classifier by making the question specify the county, but I discovered this looks bad:
So in my second commit I add the location argument to the charge creator and classifier. Now the charge is NMA only in Multnomah County: