Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NJ 156 - Added watermark to 1040 PDF #5298

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

jachan
Copy link
Contributor

@jachan jachan commented Dec 27, 2024

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • No - merge after code review approval

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Modified PDFs to add Watermark
  • Did NOT add watermark to nj_additional_dependents, as the background layer is difficult to interact with. Will discuss this PR with @aloverso to fix before merging.

How to test?

  • Walk through Blackburn_mfj, verify that PDF generated has watermark

Screenshots (for visual changes)

  • Before
image image image
  • After
image image image

@jachan jachan marked this pull request as draft December 27, 2024 16:29
Copy link

Heroku app: https://gyr-review-app-5298-dbf56504079c.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5298 (optionally add --tail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant