Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fyst 1515 add prior year access link button to homepage #5296

Open
wants to merge 5 commits into
base: FYST-1466-prior-year-access-mvp
Choose a base branch
from

Conversation

DrewProebstel
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!
  • No - merge after code review approval

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Explain the implementation goals being solved or the feature with the reviewer in mind
  • Mention any relevant issues or insights to be shared with the reviewer.
  • Alternatives considered

How to test?

  • Describe the testing approach taken to verify the changes, including:
    • Unit/integration/manual tests
    • Test data used
  • Specify any relevant testing environments used (e.g., development, staging, demo, Heroku).
  • Risk Assessment
    • Risks or side effects associated with the changes and how they were mitigated.
    • Highlight areas that may need extra attention during code review or testing.
    • Paste SQL queries or output where relevant

Screenshots (for visual changes)

  • Before
  • After

Copy link

Heroku app: https://gyr-review-app-5296-1489fbdcf0f6.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5296 (optionally add --tail)

end

def down
raise ActiveRecord::IrreversibleMigration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given this is a migration of existing data, i believe it's a fair assumption to purge the attached pdf and truncate the tables.

@DrewProebstel DrewProebstel force-pushed the FYST-1515-add-prior-year-access-link-button-to-homepage branch from db90448 to 36a8be4 Compare December 27, 2024 20:47
@anisharamnani anisharamnani changed the base branch from main to FYST-1466-prior-year-access-mvp December 27, 2024 21:22
Copy link
Contributor

@anisharamnani anisharamnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for setting up the initial flow 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants