MD502 validations

app/lib/efile/md/md502_calculator.rb

@@ -390,6 +390,8 @@ def calculate_line_21
           percent = ranges[range_index][2]
           in_excess_of = ranges[range_index][0].begin
           (base + ((taxable_net_income - in_excess_of) * percent)).round
+        else
+          0
         end
       end
 

spec/lib/efile/md/md502_calculator_spec.rb

@@ -920,8 +920,8 @@
 
     context "deduction method is 'N'" do
       let(:deduction_method) { "N" }
-      it "returns nil" do
-        expect(instance.lines[:MD502_LINE_21].value).to eq nil
+      it "returns 0" do
+        expect(instance.lines[:MD502_LINE_21].value).to eq 0
       end
     end
   end

spec/lib/submission_builder/ty2024/states/md/documents/md502_spec.rb

@@ -459,10 +459,10 @@
 
         it "leaves amounts blank if method is not standard" do
           allow_any_instance_of(Efile::Md::Md502Calculator).to receive(:calculate_deduction_method).and_return "N"
-          allow_any_instance_of(Efile::Md::Md502Calculator).to receive(:calculate_line_21).and_return nil
+          allow_any_instance_of(Efile::Md::Md502Calculator).to receive(:calculate_line_21).and_return 0
           expect(xml.at("Form502 NetIncome")).to be_nil
           expect(xml.at("Form502 StateTaxComputation TaxableNetIncome")).to be_nil
-          expect(xml.at("Form502 StateTaxComputation StateIncomeTax")).to be_nil
+          expect(xml.at("Form502 StateTaxComputation StateIncomeTax").text).to eq "0"
           expect(xml.at("Form502 StateTaxComputation PovertyLevelCredit")).to be_nil
           expect(xml.at("Form502 StateTaxComputation IndividualTaxCredits")).to be_nil
           expect(xml.at("Form502 StateTaxComputation StateTaxAfterCredits")).to be_nil