Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nj 125 income editing #5288

Draft
wants to merge 52 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 37 commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
be6ee8c
work in progress - comments on relevant lines
mluedke2 Dec 17, 2024
c4b0a65
Merge branch 'main' into nj-125-income-editing
mluedke2 Dec 17, 2024
b04f37a
one way to hide the unemployment box in nj
mluedke2 Dec 17, 2024
aaaa000
use mailing state instead
mluedke2 Dec 17, 2024
46f7b6d
hide ssa-1099 if nj as well
mluedke2 Dec 17, 2024
8848c80
only show income review if there is something to review
mluedke2 Dec 18, 2024
026f17b
share display condition logic between controller and erb
mluedke2 Dec 18, 2024
2d736b0
Merge branch 'main' into nj-125-income-editing
mluedke2 Dec 18, 2024
89fcc1a
for now just check for state is nj
mluedke2 Dec 19, 2024
bf0927f
Merge branch 'main' into nj-125-income-editing
mluedke2 Dec 19, 2024
60e06ab
remove comment for out of scope
mluedke2 Dec 19, 2024
505c8a8
remove extra comment
mluedke2 Dec 19, 2024
37bdf9c
add e2e tests for income review visual changes
mluedke2 Dec 19, 2024
648e1ae
remove unused imports
mluedke2 Dec 19, 2024
a74cca3
update lucky w2
mluedke2 Dec 20, 2024
c1192ca
nj-specific content
mluedke2 Dec 20, 2024
b0ddea4
dry and condition styling
mluedke2 Dec 20, 2024
850a75d
edit text for box14
mluedke2 Dec 20, 2024
f8465ab
Merge branch 'main' into nj-125-income-editing
mluedke2 Dec 20, 2024
1b36583
update xml for box 14
mluedke2 Dec 20, 2024
71bd8d5
Merge branch 'main' into nj-125-income-editing
mluedke2 Dec 23, 2024
1c6ba7d
sync es
mluedke2 Dec 23, 2024
5ac1833
conform to new format without slashes
mluedke2 Dec 23, 2024
fc59a55
expectations for w2 editing
mluedke2 Dec 23, 2024
496b44f
proper test for assigning box 14 values
mluedke2 Dec 23, 2024
609969e
update more syntax for the no-slash format
mluedke2 Dec 23, 2024
d23cc09
don't use shared tests for nj since it's tested separately
mluedke2 Dec 23, 2024
7bb59ea
missing key in es
mluedke2 Dec 23, 2024
34db50e
normalize strings
mluedke2 Dec 23, 2024
2826eda
Merge branch 'main' into nj-125-income-editing
mluedke2 Dec 23, 2024
ea26a0c
don't catch on conditional strings for unused test
mluedke2 Dec 23, 2024
52a2faf
rearrange translation string keys to not need to add to ignore list
mluedke2 Dec 23, 2024
fd8644f
fix syntax
mluedke2 Dec 23, 2024
92cc4ee
Merge branch 'main' into nj-125-income-editing
mluedke2 Dec 24, 2024
d8ba042
Merge branch 'main' into nj-125-income-editing
mluedke2 Dec 24, 2024
57ceb03
remove unneeded p
mluedke2 Dec 24, 2024
741c76c
Merge branch 'main' into nj-125-income-editing
mluedke2 Dec 26, 2024
0bdbedf
overwrite in model getter instead of just in controller for form, cal…
mluedke2 Dec 26, 2024
471d383
refactor to use one UI_MAX constant, and a method name that explicitl…
mluedke2 Dec 26, 2024
2876f29
fix one of the failing tests
mluedke2 Dec 26, 2024
c28f4cb
fix field name
mluedke2 Dec 27, 2024
a857576
partially undo renaming constants - still keep overwrite function name
mluedke2 Dec 27, 2024
e52ac21
use without slashes or underscores since that is XML format
mluedke2 Dec 27, 2024
341250b
work in progress - roll back to underscores
mluedke2 Dec 30, 2024
aaf6fa3
field name
mluedke2 Dec 30, 2024
1c199d7
use override for ui fields
mluedke2 Dec 30, 2024
b3b80d9
remove two nj checks
mluedke2 Dec 30, 2024
5e6ce7e
remove another nj-specific check
mluedke2 Dec 30, 2024
92dc749
fix i18n health hint
mluedke2 Dec 30, 2024
62f04eb
remove nj-specific key
mluedke2 Dec 30, 2024
4da0204
full i18n key needed for existence check
mluedke2 Dec 30, 2024
de323eb
proper current_state_code
mluedke2 Dec 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/controllers/state_file/questions/w2_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def form_params

def load_w2
@w2 = current_intake.state_file_w2s.find(params[:id])
@w2.box14_ui_wf_swf ||= @w2.box14_ui_hc_wd
@box14_codes = StateFile::StateInformationService.w2_supported_box14_codes(current_state_code)
end
end
Expand Down
2 changes: 1 addition & 1 deletion app/lib/submission_builder/return_w2.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def document

def add_box_14_node(code, node_after_box_14_codes)
field_name = "box14_#{code.downcase}".to_sym
field_as_desc = code.tr '_', '/'
field_as_desc = code.delete '_'

return if !@intake_w2[field_name].present? || !@intake_w2[field_name].positive?

Expand Down
4 changes: 2 additions & 2 deletions app/models/state_file_base_intake.rb
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ def synchronize_df_w2s_to_database
box_14_values[deduction[:other_description]] = deduction[:other_amount]
end
state_file_w2.assign_attributes(
box14_ui_wf_swf: box_14_values['UI/WF/SWF'],
box14_ui_hc_wd: box_14_values['UI/HC/WD'],
box14_ui_wf_swf: box_14_values['UIWFSWF'],
box14_ui_hc_wd: box_14_values['UIHCWD'],
box14_fli: box_14_values['FLI'],
box14_stpickup: box_14_values['STPICKUP'],
employer_ein: direct_file_w2.EmployerEIN,
Expand Down
2 changes: 1 addition & 1 deletion app/services/state_file/state_information_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def state_intake_class_names
vita_link_es: "",
voucher_form_name: "NJ Voucher Form",
voucher_path: "",
w2_supported_box14_codes: ["UI_WF_SWF", "UI_HC_WD", "FLI"],
w2_supported_box14_codes: ["UI_WF_SWF", "FLI"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why isn't this one changing to "UIWFSWF"? Is it possible to change and then we won't need to remove the _ in return_w2.rb submission builder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good catch, will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually decided to end up keeping this, because it all maps back to the DB. It could be renamed, but would require a db migration to rename the field there. (And there were about 70 uses of this throughout the app so I didn't want this diff to grow). And it is only important to not have underscores in the XML alone. If we still want to do that db field name change and related rename I'm not against it but a follow-up would be better in my opinion.

w2_include_local_income_boxes: false
},
ny: {
Expand Down
17 changes: 13 additions & 4 deletions app/views/state_file/questions/income_review/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@
<% if current_intake.direct_file_data.fed_unemployment > 0 %>
<div class="white-group unemployment" id="form1099gs">
<p class="text--bold spacing-below-0"><%= t(".unemployment_title") %></p>
<% if current_intake.state_file1099_gs.count > 0 %>
<% if current_state_code == "nj" %>
mluedke2 marked this conversation as resolved.
Show resolved Hide resolved
<p class="text--grey-bold spacing-above-15 spacing-below-0">
<%= t(".nj_not_taxed") %>
</p>
<% elsif current_intake.state_file1099_gs.count > 0 %>
<% current_intake.state_file1099_gs.each do |state_1099g| %>
<% recipient = current_intake.send(state_1099g.recipient) %>
<div class="spacing-above-25">
Expand Down Expand Up @@ -72,7 +76,7 @@
<% end %>

<% if current_intake.direct_file_json_data.interest_reports.count > 0 %>
<div class="white-group">
<div class="white-group" id="form1099ints">
<p class="text--bold spacing-below-0"><%= t(".interest_income_title") %></p>
<p class="text--grey-bold spacing-above-15 spacing-below-0">
<%= t(".interest_income_body") %>
Expand All @@ -81,10 +85,15 @@
<% end %>

<% if current_intake.direct_file_data.fed_ssb > 0 || current_intake.direct_file_data.fed_taxable_ssb > 0 %>
<div class="white-group">
<div class="white-group" id="formssa1099s">
<p class="text--bold spacing-below-0"><%= t(".ssa_title") %></p>
<p class="text--grey-bold spacing-above-15 spacing-below-0">
<%= t(".no_info_needed") %>
<%= case current_state_code
when "nj"
t(".nj_not_taxed")
else
t(".no_info_needed")
end %>
mluedke2 marked this conversation as resolved.
Show resolved Hide resolved
</p>
</div>
<% end %>
Expand Down
17 changes: 12 additions & 5 deletions app/views/state_file/questions/w2/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
<p class="spacing-below-25"><%= @w2.employer_name %></p>

<% if @box14_codes.present? %>
<% if @state_code == "nj" %>
mluedke2 marked this conversation as resolved.
Show resolved Hide resolved
<p><%= t(".box14_intro_nj_html") %></p>
<% end %>
<fieldset>
<legend class="spacing-below-5"><%= t(".box14_html") %></legend>
<% @box14_codes.each do |code| %>
Expand Down Expand Up @@ -46,13 +49,17 @@
<% end %>
</div>

<% if t(".box14_explanation.#{@state_code}_html", default: nil) %>
<% explanation_key = ".box14_explanation_#{@state_code}_html" %>
<% button_text = @state_code == "nj" ? t(".what_is_box14_nj") : t(".what_is_box14") %>
mluedke2 marked this conversation as resolved.
Show resolved Hide resolved
<% explanation_text = t(explanation_key, year: MultiTenantService.statefile.current_tax_year, default: nil) %>

<% if explanation_text %>
<div class="reveal spacing-above-35">
<p><button href="#" class="reveal__button"><%= t(".what_is_box14") %></button></p>
<button href="#" class="reveal__button"><%= button_text %></button>
<div class="reveal__content">
<p class="spacing-below-15">
<%= t(".box14_explanation.#{@state_code}_html", year: MultiTenantService.statefile.current_tax_year) %>
</p>
<p class="spacing-below-15">
<%= explanation_text %>
</p>
</div>
</div>
<% end %>
Expand Down
10 changes: 6 additions & 4 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2870,6 +2870,7 @@ en:
help_text: We will collect any missing information.
interest_income_body: No additional state info needed
interest_income_title: Interest income (1099-INT)
nj_not_taxed: This income is not taxed in New Jersey.
no_info_needed: No additional state info needed
retirement_income_title: Retirement income (1099-R)
review_and_edit_state_info: Review and edit state info
Expand Down Expand Up @@ -3758,14 +3759,14 @@ en:
verification_code_label: Enter the 6-digit code
w2:
edit:
box14_explanation:
md_html: For tax year %{year}, we will only process the <strong>STPICKUP</strong> code, which represents any contributions you made to the state retirement system.
box14_explanation_md_html: For tax year %{year}, we will only process the <strong>STPICKUP</strong> code, which represents any contributions you made to the state retirement system.
mluedke2 marked this conversation as resolved.
Show resolved Hide resolved
box14_explanation_nj_html: 'For this year, we will only need the amounts for <strong>UI/WF/SWF</strong> (may also appear as <strong>"UI/HC/WD"</strong> on your W2) and FLI.<br/><br/><strong>If you do not see these, please leave these fields blank.</strong><br/><br/><strong>Definitions:</strong><br/><br/><strong>UI/WF/SWF</strong> (may also appear as <strong>"UI/HC/WD"</strong> on your W2) represents:<ul><li><strong>UI</strong> refers to unemployment insurance contributions</li><li><strong>WF</strong> and <strong>WD</strong> refer to workforce development partnership fund contributions</li><li><strong>SWF</strong> refers to supplemental workforce fund contributions</li><li><strong>HC</strong> refers to healthcare contributions</li><li><strong>WD</strong> refers to workforce development contributions</li></ul><strong>FLI</strong>: Represents contributions withheld for Family Leave Insurance. Family Leave Insurance (FLI) provides paid leave benefits to bond with a new child, care for a loved one, or cope with domestic/sexual violence. If you have a number for this on your paycheck, it means you have paid into this program and may be eligible to receive cash benefits.<br/><br/>We use the amounts to determine if you might be eligible for a credit.<br/><br/>There may be other information in box 14 - those don''t need to be reported with this tool.'
mluedke2 marked this conversation as resolved.
Show resolved Hide resolved
box14_fli_html: "<strong>FLI</strong>"
box14_html: "<strong>Box 14,</strong> Other"
box14_intro_nj_html: Box 14 will have various letters in it. Those letters all represent program names.<br/><br/>For this year, we will only need the amounts for <strong>UI/WF/SWF</strong> (may also appear as <strong>"UI/HC/WD"</strong> on your W2) <strong>and FLI</strong>.<br/><br/><strong>If you do not see these, please leave these fields blank.</strong><br/><br/>There may be information for other programs in box 14 - those don't need to be reported with this tool.
box14_stpickup_help_text: For %{year}, we will only process the STPICKUP code. If you do not see this code or have other codes in Box 14, please leave it blank.
box14_stpickup_html: "<strong>STPICKUP</strong>"
box14_ui_hc_wd_html: "<strong>UI/HC/WD</strong>"
box14_ui_wf_swf_html: "<strong>UI/WF/SWF</strong>"
box14_ui_wf_swf_html: "<strong>UI/WF/SWF</strong> (This may also appear on your W2 as <strong>UI/HC/WD.</strong>)"
box15_html: "<strong>Box 15,</strong> Employer’s state ID number"
box16_html: "<strong>Box 16,</strong> State wages, tips, etc."
box17_html: "<strong>Box 17,</strong> State income tax"
Expand All @@ -3783,6 +3784,7 @@ en:
state_wages_exceed_amt_error: Total state wages and tips cannot be greater than $%{wages_amount}
wages_amt_error: Total income tax cannot be greater than $%{wages_amount}
what_is_box14: What could be in Box 14?
what_is_box14_nj: What should I put in Box 14?
waiting_to_load_data:
edit:
subtitle_html: This usually takes a few minutes. Don’t close this page.<br><br> We’ll use your federal tax return information to complete sections of your state return.
Expand Down
10 changes: 6 additions & 4 deletions config/locales/es.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2828,6 +2828,7 @@ es:
help_text: Te pediremos que nos compartas la información que pueda faltar.
interest_income_body: No se necesita información estatal adicional
interest_income_title: Ingresos por intereses (1099-INT)
nj_not_taxed: This income is not taxed in New Jersey.
no_info_needed: No se necesita información estatal adicional
retirement_income_title: Jubilación (1099-R)
review_and_edit_state_info: Revisar y editar la información estatal
Expand Down Expand Up @@ -3732,14 +3733,14 @@ es:
verification_code_label: Ingresa el código de 6 dígitos
w2:
edit:
box14_explanation:
md_html: Para el año fiscal %{year}, solo procesaremos el código <strong>STPICKUP</strong>, que representa las contribuciones que hiciste al sistema de jubilación estatal.
box14_explanation_md_html: Para el año fiscal %{year}, solo procesaremos el código <strong>STPICKUP</strong>, que representa las contribuciones que hiciste al sistema de jubilación estatal.
box14_explanation_nj_html: 'For this year, we will only need the amounts for <strong>UI/WF/SWF</strong> (may also appear as <strong>"UI/HC/WD"</strong> on your W2) and FLI.<br/><br/><strong>If you do not see these, please leave these fields blank.</strong><br/><br/><strong>Definitions:</strong><br/><br/><strong>UI/WF/SWF</strong> (may also appear as <strong>"UI/HC/WD"</strong> on your W2) represents:<ul><li><strong>UI</strong> refers to unemployment insurance contributions</li><li><strong>WF</strong> and <strong>WD</strong> refer to workforce development partnership fund contributions</li><li><strong>SWF</strong> refers to supplemental workforce fund contributions</li><li><strong>HC</strong> refers to healthcare contributions</li><li><strong>WD</strong> refers to workforce development contributions</li></ul><strong>FLI</strong>: Represents contributions withheld for Family Leave Insurance. Family Leave Insurance (FLI) provides paid leave benefits to bond with a new child, care for a loved one, or cope with domestic/sexual violence. If you have a number for this on your paycheck, it means you have paid into this program and may be eligible to receive cash benefits.<br/><br/>We use the amounts to determine if you might be eligible for a credit.<br/><br/>There may be other information in box 14 - those don''t need to be reported with this tool.'
box14_fli_html: "<strong>FLI</strong>"
box14_html: "<strong>Box 14,</strong> Other"
box14_intro_nj_html: Box 14 will have various letters in it. Those letters all represent program names.<br/><br/>For this year, we will only need the amounts for <strong>UI/WF/SWF</strong> (may also appear as <strong>"UI/HC/WD"</strong> on your W2) <strong>and FLI</strong>.<br/><br/><strong>If you do not see these, please leave these fields blank.</strong><br/><br/>There may be information for other programs in box 14 - those don't need to be reported with this tool.
box14_stpickup_help_text: Para %{year}, solo procesaremos el código STPICKUP. Si no ves este código o tienes otros códigos en Box 14, por favor déjalo en blanco.
box14_stpickup_html: "<strong>STPICKUP</strong>"
box14_ui_hc_wd_html: "<strong>UI/HC/WD</strong>"
box14_ui_wf_swf_html: "<strong>UI/WF/SWF</strong>"
box14_ui_wf_swf_html: "<strong>UI/WF/SWF</strong> (This may also appear on your W2 as <strong>UI/HC/WD.</strong>)"
box15_html: "<strong>Box 15,</strong> Employer’s state ID number"
box16_html: "<strong>Box 16</strong>, State wages, tips, etc."
box17_html: "<strong>Box 17</strong>, State income tax"
Expand All @@ -3757,6 +3758,7 @@ es:
state_wages_exceed_amt_error: El total de salarios e ingresos estatales no puede ser mayor que $%{wages_amount}
wages_amt_error: El impuesto sobre la renta total no puede ser mas de $%{wages_amount}
what_is_box14: "¿Qué podría haber en Box 14?"
what_is_box14_nj: What should I put in Box 14?
waiting_to_load_data:
edit:
subtitle_html: Esto suele tardar unos minutos. No cierres esta página<br><br> Usaremos la información de tu declaración de impuestos federal para completar secciones de tu declaración estatal.
Expand Down
30 changes: 29 additions & 1 deletion spec/controllers/state_file/questions/w2_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -198,4 +198,32 @@
end
end
end
end

describe "#load_w2" do
context "when box14_ui_wf_swf is nil and box14_ui_hc_wd is not" do
let(:intake) { create :state_file_nj_intake }
let!(:state_file_w2) do
create :state_file_w2, state_file_intake: intake, w2_index: 1,
box14_ui_wf_swf: nil, box14_ui_hc_wd: 340
end

it "sets box14_ui_wf_swf to box14_ui_hc_wd" do
get :edit, params: { id: state_file_w2.id }
mluedke2 marked this conversation as resolved.
Show resolved Hide resolved
expect(assigns(:w2).box14_ui_wf_swf).to eq 340
end
end

context "when both box14_ui_wf_swf and box14_ui_hc_wd are not nil" do
let(:intake) { create :state_file_nj_intake }
let!(:state_file_w2) do
create :state_file_w2, state_file_intake: intake, w2_index: 1,
box14_ui_wf_swf: 450, box14_ui_hc_wd: 340
end

it "sets box14_ui_wf_swf to box14_ui_wf_swf" do
get :edit, params: { id: state_file_w2.id }
expect(assigns(:w2).box14_ui_wf_swf).to eq 450
end
end
end
end
74 changes: 74 additions & 0 deletions spec/features/state_file/income_review_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
require "rails_helper"

RSpec.feature "Income Review", active_job: true do
include StateFileIntakeHelper

before do
allow_any_instance_of(Routes::StateFileDomain).to receive(:matches?).and_return(true)
end

context "NJ", :flow_explorer_screenshot, js: true do
def advance_to_data_transfer
visit "/"
click_on "Start Test NJ"
click_on "Get Started", id: "firstCta"
click_on I18n.t("general.continue")
step_through_initial_authentication(contact_preference: :email)
check "Text message"
fill_in "Your phone number", with: "+12025551212"
click_on "Continue"
click_on I18n.t("general.accept")
click_on I18n.t("state_file.questions.terms_and_conditions.edit.accept")
end

it(
"displays review and edit pages with w2s, unemployment, and social security income",
required_schema: "nj"
) do
advance_to_data_transfer

step_through_df_data_transfer("Transfer Zeus box 14")

expect(page).to have_text I18n.t("state_file.questions.income_review.edit.title")
expect(page).to have_text I18n.t("state_file.questions.income_review.edit.w2s_title")

within '#form1099gs' do
expect(page).to have_text I18n.t("state_file.questions.income_review.edit.unemployment_title")
expect(page).to have_text I18n.t("state_file.questions.income_review.edit.nj_not_taxed")
end

within '#formssa1099s' do
expect(page).to have_text I18n.t("state_file.questions.income_review.edit.ssa_title")
expect(page).to have_text I18n.t("state_file.questions.income_review.edit.nj_not_taxed")
end

click_on I18n.t("state_file.questions.income_review.edit.review_and_edit_state_info")

# STPICKUP 250
# UIWFSWF 350
# UIHCWD 450
# FLI 550

expect(page).to have_field('state_file_w2_box14_ui_wf_swf', with: '350.0')
expect(page).to have_field('state_file_w2_box14_fli', with: '550.0')
expect(page).to have_field('state_file_w2_employer_state_id_num', with: '12345')
expect(page).to have_field('state_file_w2_state_wages_amount', with: '12345.0')
expect(page).to have_field('state_file_w2_state_income_tax_amount', with: '500.0')
expect(page).to have_button("What should I put in Box 14?")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PEBBLE] Original tests in review_page_spec test that clicking continue takes you back to the review screen. Since we're removing NJ from those tests, mind putting that check here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true - will make sure that everything that was tested before is still covered...

end

it "displays with investment income", required_schema: "nj" do
advance_to_data_transfer

step_through_df_data_transfer("Transfer Streep single inv limit")

expect(page).to have_text I18n.t("state_file.questions.income_review.edit.title")
expect(page).to have_text I18n.t("state_file.questions.income_review.edit.w2s_title")

within '#form1099ints' do
expect(page).to have_text I18n.t("state_file.questions.income_review.edit.interest_income_title")
expect(page).to have_text I18n.t("state_file.questions.income_review.edit.no_info_needed")
end
end
end
end
2 changes: 1 addition & 1 deletion spec/features/state_file/review_page_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
allow_any_instance_of(Routes::StateFileDomain).to receive(:matches?).and_return(true)
end

StateFile::StateInformationService.active_state_codes.without("nc").each do |state_code|
StateFile::StateInformationService.active_state_codes.without("nc", "nj").each do |state_code|
context "#{state_code.upcase}", js: true do
it "allows user to navigate to income review page, edit an income form, and then navigate back to final review page", required_schema: state_code do
set_up_intake_and_associated_records(state_code)
Expand Down
28 changes: 20 additions & 8 deletions spec/fixtures/state_file/fed_return_xmls/nj/lucky_single.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<SSN>400006306</SSN>
<AlternativeMediaCd>01</AlternativeMediaCd>
</IRS9000>
<IRSW2 documentId="W20001" documentName="IRSW2">
<IRSW2 documentName="IRSW2" documentId="W20001">
<EmployeeSSN>400006306</EmployeeSSN>
<EmployerEIN>221236333</EmployerEIN>
<EmployerNameControlTxt>WEAR</EmployerNameControlTxt>
Expand All @@ -75,9 +75,9 @@
</EmployerName>
<EmployerUSAddress>
<AddressLine1Txt>1 Clothing St</AddressLine1Txt>
<CityNm>Fairfield</CityNm>
<StateAbbreviationCd>CT</StateAbbreviationCd>
<ZIPCd>06510</ZIPCd>
<CityNm>New Brunwick</CityNm>
<StateAbbreviationCd>NJ</StateAbbreviationCd>
<ZIPCd>08904</ZIPCd>
</EmployerUSAddress>
<EmployeeNm>Tess L Lucky</EmployeeNm>
<EmployeeUSAddress>
Expand All @@ -87,15 +87,27 @@
<ZIPCd>08619</ZIPCd>
</EmployeeUSAddress>
<WagesAmt>40565</WagesAmt>
<WithholdingAmt>2000</WithholdingAmt>
<WithholdingAmt>8000</WithholdingAmt>
<SocialSecurityWagesAmt>40565</SocialSecurityWagesAmt>
<SocialSecurityTaxAmt>1000</SocialSecurityTaxAmt>
<SocialSecurityTaxAmt>6000</SocialSecurityTaxAmt>
<MedicareWagesAndTipsAmt>40565</MedicareWagesAndTipsAmt>
<MedicareTaxWithheldAmt>500</MedicareTaxWithheldAmt>
<MedicareTaxWithheldAmt>4000</MedicareTaxWithheldAmt>
<OtherDeductionsBenefitsGrp>
<Desc>FLI</Desc>
<Amt>145</Amt>
</OtherDeductionsBenefitsGrp>
<OtherDeductionsBenefitsGrp>
<Desc>UIHCWD</Desc>
<Amt>140</Amt>
</OtherDeductionsBenefitsGrp>
<OtherDeductionsBenefitsGrp>
<Desc>UIWFSWF</Desc>
<Amt>180</Amt>
</OtherDeductionsBenefitsGrp>
<W2StateLocalTaxGrp>
<W2StateTaxGrp>
<StateAbbreviationCd>NJ</StateAbbreviationCd>
<EmployerStateIdNum>654321</EmployerStateIdNum>
<EmployerStateIdNum>221236333</EmployerStateIdNum>
<StateWagesAmt>40000</StateWagesAmt>
<StateIncomeTaxAmt>400</StateIncomeTaxAmt>
<W2LocalTaxGrp/>
Expand Down
Loading
Loading