Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fyst 1387 remove employment question from excise credit page #5257

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mrotondo
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • The story calls for us to handle the "SSN not valid for employment" status on a per-filer basis, instead of per-intake. I removed relevant question from the form, removed the field from StateFileAzIntake and used the JSON data directly when determining how many filers are eligible for excise credit

How to test?

  • Ideally, this should be tested for six separate cases:
    • non-mfj with valid-for-employment SSN (gets excise credit)
    • non-mfj with not-valid-for-employment SSN (does not get excise credit)
    • mfj with spouse not-valid-for-employment SSN (gets excise credit for one fewer household member)
    • mfj with primary not-valid-for-employment SSN (gets excise credit for one fewer household member)
    • mfj with both not-valid-for-employment SSN (does not get excise credit)
    • mfj with neither not-valid-for-employment SSN (gets excise credit with both filer and spouse included)
  • Automated tests have been added that cover these scenarios

Screenshots (for visual changes)

  • Before
image - After image

Copy link
Contributor

@tahsinaislam tahsinaislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mrotondo mrotondo closed this Dec 23, 2024
@mrotondo mrotondo reopened this Dec 23, 2024
Copy link

Heroku app: https://gyr-review-app-5257-640fc04326b4.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5257 (optionally add --tail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants