Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GYR1-605 Add visa question and flip citizen question on life situations screens #5246

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

spompea-cfa
Copy link
Contributor

@spompea-cfa spompea-cfa commented Dec 19, 2024

Link to JIRA issue

Is PM acceptance required?

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Flipped the US citizen question (so it's phrased in an affirmative manner) on the primary/spouse life situations screens.
  • Added a new question to those screens about being on a visa

How to test?

  • The standard GYR UI/UX process should be fine here.
  • Should confirm that the citizen and visa answers, when submitted via the flow, do show up properly in the Hub

Screenshots (for visual changes)

  • Before: see flows
  • After:
primary life situations EN - Screenshot 2024-12-19 at 7 11 14 PM primary life situations ES - Screenshot 2024-12-19 at 7 11 29 PM spouse life situations EN - Screenshot 2024-12-19 at 7 12 37 PM spouse life situations ES - Screenshot 2024-12-19 at 7 12 07 PM

Copy link

Heroku app: https://gyr-review-app-5246-72a620d2a111.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5246 (optionally add --tail)

@spompea-cfa spompea-cfa force-pushed the gyr1-605-life-situations-citizen-and-visa-questions branch from e974d89 to 4c2700e Compare December 19, 2024 23:24
@spompea-cfa spompea-cfa changed the title [WIP] GYR1-605 Add visa question and flip citizen question on life situations screens GYR1-605 Add visa question and flip citizen question on life situations screens Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant