Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FYST-1274] WIP #5130

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[FYST-1274] WIP #5130

wants to merge 1 commit into from

Conversation

jnf
Copy link
Contributor

@jnf jnf commented Dec 6, 2024

be sure to reference the latest submission in the 'download pdf' button on the submision confirmation page

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!
  • No - merge after code review approval

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Explain the implementation goals being solved or the feature with the reviewer in mind
  • Mention any relevant issues or insights to be shared with the reviewer.
  • Alternatives considered

How to test?

  • Describe the testing approach taken to verify the changes, including:
    • Unit/integration/manual tests
    • Test data used
  • Specify any relevant testing environments used (e.g., development, staging, demo, Heroku).
  • Risk Assessment
    • Risks or side effects associated with the changes and how they were mitigated.
    • Highlight areas that may need extra attention during code review or testing.
    • Paste SQL queries or output where relevant

Screenshots (for visual changes)

  • Before
  • After

@jnf jnf added the wip denotes a work in progress that isn't ready for formal review label Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Heroku app: https://gyr-review-app-5130-2260a7e4e069.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5130 (optionally add --tail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip denotes a work in progress that isn't ready for formal review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant