Enable the session continuity interceptor (part of FFB). #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spokenbird here's a pass at this. I think we should skip this for the current release, but try for the next one. There are a few things to be worked out as I don't think this is quite right yet. And I think the ffl needs a change as well to address an issue in the session interceptor code. At any rate, this is a first pass, but I don't feel confident moving forward with this as I think it will still throw an error when a session times out. |
bseeger
commented
May 23, 2024
| } else { | ||
| implementation "org.codeforamerica.platform:form-flow:${formFlowLibraryVersion}" | ||
| println "📚Using form flow library ${formFlowLibraryVersion}" | ||
| } |
There was a problem hiding this comment.
These if / else's are temporary.
|
|
Users will get redirected to the first page in the event of a session timeout. This will prevent users from continuing on w/o knowing that their session expired and their record is now split. Remove creation of a session in static page controller, as this is not necessary.
WIP: Still needs work.
bseeger
force-pushed
the
add_session_interceptor
branch
from
90a6c22 to
065e50e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users will get redirected to the index page in the event of a session timeout. This will prevent users from continuing on w/o knowing that their session expired and their record is now split.
Remove creation of a session in static page controller, as this is not necessary.